feat: generic Transaction #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grumbach
force-pushed
the
generic_transfers
branch
from
97ec197 to
4c22ff9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| service.service_data.service_name, | ||
| wallet.balance() | ||
| ); | ||
| // TODO: remove this as we have no way to know the reward balance of nodes since EVM payments! |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| } | ||
| Err(_) => node.reward_balance = None, | ||
| } | ||
| // TODO: remove this as we have no way to know the reward balance of nodes since EVM payments! |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
grumbach
force-pushed
the
generic_transfers
branch
5 times, most recently
from
e7bd7ff to
1e114a6
Compare
maqi
approved these changes
Nov 29, 2024
maqi
force-pushed
the
generic_transfers
branch
from
1e114a6 to
ebb8702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransactionData typeSpendsn_transfersandsn_auditorwhich revolved around spends and are 100% DEAD CODE